Normalize RepoRoot to include trailing slash#7498
Merged
ViktorHofer merged 11 commits intomainfrom Jun 10, 2021
Merged
Conversation
The Arcade SDK defines the RepoRoot repository [with a trailing slash](https://github.com/dotnet/arcade/blob/e81d8c9bdc1de22623657afb23fab210dd04ca82/src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props#L23) but the build scripts (build.ps1 and build.sh) pass in the property without a trailing slash which makes the use of it inconsistent and led to this source build patch: https://github.com/dotnet/runtime/blob/23e4735e5cc9956d3f3b351a252f0b1622a14cec/eng/source-build-patches/0004-Add-trailing-path-separator-to-repo_root.patch. Normalizing the variable in the build scripts so that the property always contains the trailing slash.
MichaelSimons
approved these changes
Jun 10, 2021
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
dseefeld
approved these changes
Jun 10, 2021
Contributor
|
@ViktorHofer This seems to have broken the official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1181292&view=results |
Member
Author
|
Oh no :( Should I send a follow-up change? |
Contributor
|
I haven't had a chance to dig in just yet, so if it's obvious please do, if not we can revert while we figure it out |
Contributor
|
OOOh, actually, let's hold for a minute. I'm seeing this exact same error in other places, which makes me think it's not the change. |
Contributor
|
oh, nevermind, it's definitely this change, I forgot for a minute that the publishing pipeline uses arcade main. We need to revert this change asap because it's failing publishing for everyone. |
riarenas
added a commit
to riarenas/arcade
that referenced
this pull request
Jun 10, 2021
This reverts commit a419173.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arcade SDK defines the RepoRoot repository with a trailing slash but the build scripts (build.ps1 and build.sh) pass in the property without a trailing slash which makes the use of it inconsistent and led to this source build patch: https://github.com/dotnet/runtime/blob/23e4735e5cc9956d3f3b351a252f0b1622a14cec/eng/source-build-patches/0004-Add-trailing-path-separator-to-repo_root.patch.
Normalizing the variable in the build scripts so that the property always contains the trailing slash.
To double check: